Add ability to override where tokens are read from. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for testing code that reads the token.
mjrossi
approved these changes
Oct 9, 2024
tt
approved these changes
Oct 10, 2024
| // By default they are retrieved via [os.Open] and [os.ReadFile]. | ||
| // | ||
| // This is useful when testing code that uses DynoID. | ||
| var DefaultFS fs.ReadFileFS = &osReader{} |
There was a problem hiding this comment.
Would LocalFS maybe be better to match the method naming?
There was a problem hiding this comment.
I was just following the convention from other Go packages in the stdlib. But then again they do have a set of methods that works on the default and another set that allows you to instantiate or pass in your own. 🤷
I think I'll leave it for now and we can re-visit as we play with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Links