optimize: the registered address #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyenought
changed the title
li-jin-gou
reviewed
Sep 26, 2023
a631807682
reviewed
Sep 26, 2023
a631807682
reviewed
Sep 26, 2023
a631807682
reviewed
Sep 26, 2023
There was a problem hiding this comment.
https://github.com/hertz-contrib/registry/pull/90/files#diff-b3ac597ed93b27ef58d5181e8dc8fc7f42b5d07fb2170fba0725bd6044bfafa1L126
register 的 serviceKey 里面没改
- _, err = e.etcdClient.Put(ctx, serviceKey(info.ServiceName, info.Addr.String()), string(val), clientv3.WithLease(leaseID))
+ _, err = e.etcdClient.Put(ctx, serviceKey(info.ServiceName, addr), string(val), clientv3.WithLease(leaseID))
我太马虎了 |
li-jin-gou
reviewed
Sep 26, 2023
a631807682
approved these changes
Sep 26, 2023
li-jin-gou
approved these changes
Sep 26, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
What this PR does / why we need it (English/Chinese):
添加根据 环境变量 动态获取 ip port 的能力
Which issue(s) this PR fixes: