Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network list server count format #783

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jun 19, 2024

The server count would previously show "0 server" instead of "0 servers"

The server count would previously show "0 server" instead of "0 servers"
@phm07 phm07 added the bug label Jun 19, 2024
@phm07 phm07 self-assigned this Jun 19, 2024
@phm07 phm07 requested a review from a team as a code owner June 19, 2024 11:49
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.74%. Comparing base (eacb7dd) to head (23e3cf4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   59.32%   59.74%   +0.41%     
==========================================
  Files         203      209       +6     
  Lines        7460     7634     +174     
==========================================
+ Hits         4426     4561     +135     
- Misses       2400     2432      +32     
- Partials      634      641       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit f69d261 into main Jun 19, 2024
5 checks passed
@phm07 phm07 deleted the fix-network-list-format branch June 19, 2024 12:15
phm07 pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.44.0](v1.43.1...v1.44.0)
(2024-06-20)


### Features

* delete multiple resources in parallel
([#761](#761))
([f2fb321](f2fb321))
* improve toml formatting
([#758](#758))
([eacb7dd](eacb7dd))
* **load-balancer:** allow specifying health check options in
add-service ([#743](#743))
([2cd08b2](2cd08b2)),
closes [#742](#742)
* new action waiting progress
([#749](#749))
([9e30f3f](9e30f3f))
* new configuration system, config subcommand
([#736](#736))
([d1c6678](d1c6678))
* **server-type:** add deprecated column to list command
([#780](#780))
([906f864](906f864))
* **server:** add default-ssh-keys option
([#759](#759))
([9b34d26](9b34d26))


### Bug Fixes

* **firewall:** 'create --rules-file' not working with outbound rules
([#752](#752))
([2f2be32](2f2be32)),
closes [#750](#750)
* network list server count format
([#783](#783))
([f69d261](f69d261))
* track progress if the terminal width allows it
([#768](#768))
([069fffe](069fffe)),
closes [#767](#767)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants