refactor: generate old deployment manifest from chart

.github/workflows/test.yml

@@ -18,15 +18,29 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      - name: Verify manifests are up to date
-        run: |
-          kustomize build deploy/kubernetes > /tmp/hcloud-csi.yml
-          # Workaround for kustomize stripping all comments. This comment is
-          # needed to automatically bump the referenced container tag through
-          # release-please
-          sed -i '/hetznercloud\/hcloud-csi-driver/ s/$/ # x-release-please-version/' /tmp/hcloud-csi.yml
-          diff deploy/kubernetes/hcloud-csi.yml /tmp/hcloud-csi.yml
+
       - name: Run tests
         run: |
           go vet ./...
           go test $(go list ./... | grep -v e2e) -v
+
+  deploy-manifests:
+    name: Check deployment manifests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: yokawasa/action-setup-kube-tools@v0.9.3
+        with:
+          setup-tools: |
+            helm
+          helm: v3.11.2
+
+      - uses: actions/checkout@v4
+      - name: Generate manifests from helm chart
+        run: hack/update-deployment-yamls.sh
+
+      - name: Check for diff
+        run: git diff --exit-code -- deploy/
+
+      - name: Show warning
+        if: ${{ failure() }}
+        run: echo "::error title=Deployment Manifests outdated::Please run hack/update-deployment-yamls.sh and commit the changes to deploy/"

chart/templates/controller/deployment.yaml

@@ -7,6 +7,7 @@ metadata:
   namespace: {{ include "common.names.namespace" . | quote }}
   labels: {{- include "common.labels.standard" . | nindent 4 }}
     app.kubernetes.io/component: controller
+    app: hcloud-csi-controller # Compatibility with old manifests
     {{- if .Values.commonLabels }}
     {{- include "common.tplvalues.render" ( dict "value" .Values.commonLabels "context" $ ) | nindent 4 }}
     {{- end }}
@@ -19,8 +20,13 @@ spec:
   strategy: {{- toYaml .Values.controller.updateStrategy | nindent 4 }}
   {{- end }}
   selector:
-    matchLabels: {{- include "common.labels.matchLabels" . | nindent 6 }}
+    matchLabels:
+      {{- if .Values.controller.matchLabelsOverride }}
+      {{- toYaml .Values.controller.matchLabelsOverride | nindent 6 }}
+      {{- else }}
+      {{- include "common.labels.matchLabels" . | nindent 6 }}
       app.kubernetes.io/component: controller
+      {{- end }}
   template:
     metadata:
       {{- if .Values.controller.podAnnotations }}

chart/templates/node/daemonset.yaml

@@ -5,6 +5,7 @@ metadata:
   namespace: {{ include "common.names.namespace" . | quote }}
   labels: {{- include "common.labels.standard" . | nindent 4 }}
     app.kubernetes.io/component: node
+    app: hcloud-csi # Compatibility with old manifests
     {{- if .Values.commonLabels }}
     {{- include "common.tplvalues.render" ( dict "value" .Values.commonLabels "context" $ ) | nindent 4 }}
     {{- end }}
@@ -16,8 +17,13 @@ spec:
   updateStrategy: {{- toYaml .Values.node.updateStrategy | nindent 4 }}
   {{- end }}
   selector:
-    matchLabels: {{- include "common.labels.matchLabels" . | nindent 6 }}
+    matchLabels:
+      {{- if .Values.node.matchLabelsOverride }}
+      {{- toYaml .Values.node.matchLabelsOverride | nindent 6 }}
+      {{- else }}
+      {{- include "common.labels.matchLabels" . | nindent 6 }}
       app.kubernetes.io/component: node
+      {{- end }}
   template:
     metadata:
       {{- if .Values.node.podAnnotations }}

chart/values.yaml

@@ -297,6 +297,11 @@ controller:
   ##
   podLabels: {}
 
+  ## @param controller.matchLabelsOverride Override the default spec.selector.matchLabels. Added for backwards compatibility with the static manifests.
+  ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates
+  ##
+  # matchLabelsOverride: null
+
   ## @param controller.podAnnotations Annotations for controller pods
   ## ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
   ##
@@ -567,6 +572,11 @@ node:
   ##
   podLabels: {}
 
+  ## @param node.matchLabelsOverride Override the default spec.selector.matchLabels. Added for backwards compatibility with the static manifests.
+  ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#pod-selector
+  ##
+  # matchLabelsOverride: {}
+
   ## @param node.podAnnotations Annotations for node pods
   ## ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
   ##