Docker Swarm support: Remove mock staging/unstaging once possible #382
Comments
s4ke
changed the title
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
|
This should work without by now. I havent gotten around to preparing a PR yet. |
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
|
Hey @s4ke, could you implement this? |
|
Yes I can, but I have to see where it fits my schedule. Any hard deadline for when you want this in? |
|
Wonderful :) No deadline, would just love to see this done before the stale bot tries to close it again (~3 months) |
|
May I ask you to remind me if this is still not done in let's say, 1 month? Sorry, currently a bit busy :) |
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
|
Well, I forgot about it :D @s4ke ping. |
|
Same here. If anyone else wants to take this, this is probably also a good first issue since it is just about removing operations and testing once against a Swarm. |
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
|
If anyone wants to send a PR:
|
) With the merge of moby/swarmkit#3116 the mock staging/unstaging is not needed anymore. It was introduced in our csi-driver in this commit: 619fa5c. Which is part of a large PR (squashed commit) that included experimental support for Docker swarm. See: - #376 - #382 ---------
In the original PR #376 we added a workaround where we added mock staging/unstaging support that will not be needed anymore once moby/swarmkit#3116 is merged.
This issue is here to track this TODO.
The text was updated successfully, but these errors were encountered: