-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): add Helm Chart #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not finish my review, but here is already a few points:
- Could we add tests for this ? The templating mixed with yaml feels a bit messy and I fear that it might hide a bunch of bugs. What about generating a set of charts with different
.Values
and compare it to some snapshots we keep in the repo? - Could we reduce the complexity by writing good documentation instead of making the chart overly complex and handling every last field (e.g. not build the image field) ?
- Some files have an inconsistent naming, for example pbd.yaml or extra-list.yaml. I would also be in favor of using kebab case filenames.
- Should we introduce a values.schema.json file to validate the values files ?
> [!WARNING] | ||
> The Helm Chart is not yet published and the instructions below will not work until the next release (v2.5.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not release 2.5.0 right after this is merged ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to force our hands one this. I was planning on deploying the Chart to my personal cluster before creating a release, but I can also do that from this PR.
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
2fed332
to
4e3282a
Compare
For sure, we already do that with the existing deployment manifest. I added two additional snapshots: default values & production example.
Removed
Sounds good :) In the latest push. |
Nice! |
I added an additional snapshot test that defines all optional values to make sure everything works. While doing that I found a bunch of features that did not work properly and fixed those. I still want to do some manual testing before merging. |
Manual testing went well. I also updated my personal cluster to use the chart from this branch and everything worked as expected :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort to build the snapshots tests! 💯
Co-authored-by: batistein <sven.batista-steinbach@syself.com>
What this PR does
Reviewer Notes
This replaces #398 as I did not have push permissions for the branch.
I recommend reviewing by commit, to reduce the noise. This is still a huge PR and if requested I can split it up into multiple.
A lot of the scripts and goreleaser config was shamelessly stolen from hcloud-cloud-controller-manager.