Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cleanup resources after e2e tests #641

Merged
merged 2 commits into from
Jun 24, 2024
Merged

ci: cleanup resources after e2e tests #641

merged 2 commits into from
Jun 24, 2024

Conversation

apricote
Copy link
Member

Remove all deployed resources to avoid running into limit errors.

Remove all deployed resources to avoid running into limit errors.
@apricote apricote added the enhancement New feature or request label Jun 24, 2024
@apricote apricote self-assigned this Jun 24, 2024
@apricote apricote requested a review from a team as a code owner June 24, 2024 09:22
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.16%. Comparing base (89e3781) to head (a1449b9).
Report is 1 commits behind head on main.

Current head a1449b9 differs from pull request most recent head 7031333

Please upload reports for the commit 7031333 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files          12       12           
  Lines        1169     1169           
=======================================
  Hits          528      528           
  Misses        618      618           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member

jooola commented Jun 24, 2024

Hmm, does the k8s tests cleanup the volumes if the test fail? Because I am not sure if we clean volumes with the terraform module.

@apricote
Copy link
Member Author

We dont, the kubernetes csi tests try to clean those up if possible. I could add a hcloud volume delete $(hcloud volume list -o noheader -o columns=id) after taking down the env. (With a check for empty list)

@jooola
Copy link
Member

jooola commented Jun 24, 2024

We dont, the kubernetes csi tests try to clean those up if possible. I could add a hcloud volume delete $(hcloud volume list -o noheader -o columns=id) after taking down the env. (With a check for empty list)

Let's see how that goes, if we stumble on a problem again we'll add the command.

@apricote apricote merged commit f65e593 into main Jun 24, 2024
3 of 8 checks passed
@apricote apricote deleted the ci-env-cleanup branch June 24, 2024 09:48
lukasmetzner pushed a commit that referenced this pull request Oct 10, 2024
Remove all deployed resources to avoid running into limit errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants