feat: truncate poll exponential backoff function to max 10s #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to increase the max to something between 5s and 30s |
jooola
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 34.01% 33.92% -0.09%
==========================================
Files 19 19
Lines 1623 1627 +4
==========================================
Hits 552 552
- Misses 1037 1041 +4
Partials 34 34 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 5, 2024
jooola
pushed a commit
that referenced
this pull request
Aug 8, 2024
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2024-08-08) ### Features * truncate poll exponential backoff function to max 10s ([#674](#674)) ([5785418](5785418)) ### Bug Fixes * xfs options compatibility between alpine and node kernel ([#689](#689)) ([13d853b](13d853b)), closes [#648](#648) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
Related to #346 and #380 The initial exponential back off algorithm introduced in #380 was not truncated, which could lead to very long intervals. The recent release of hcloud-go truncated the default exponential back off algorithm to 60s: hetznercloud/hcloud-go@fd1f46c If we take the scenario described in #346, I think we can still reduce the max interval value for the exponential back off algorithm to <30s.
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2024-08-08) ### Features * truncate poll exponential backoff function to max 10s ([#674](#674)) ([5785418](5785418)) ### Bug Fixes * xfs options compatibility between alpine and node kernel ([#689](#689)) ([13d853b](13d853b)), closes [#648](#648) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #346 and #380
The initial exponential back off algorithm introduced in #380 was not truncated, which could lead to very long intervals. The recent release of hcloud-go truncated the default exponential back off algorithm to 60s: hetznercloud/hcloud-go@fd1f46c
If we take the scenario described in #346, I think we can still reduce the max interval value for the exponential back off algorithm to <30s.