Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Switched to k8s.io/mount-utils #749

Merged
merged 3 commits into from
Oct 18, 2024
Merged

refactor: Switched to k8s.io/mount-utils #749

merged 3 commits into from
Oct 18, 2024

Conversation

lukasmetzner
Copy link
Contributor

@lukasmetzner lukasmetzner commented Oct 17, 2024 •
edited
Loading

Replaced our code for formatting and other disk related functions to k8s.io/mount-utils. This leaves only code that is related to LUKS.

BEGIN_COMMIT_OVERRIDE
feat: fstype is directly passed to mkfs: mkfs. (#749)
refactor: switched to k8s.io/mount-utils (#749)
END_COMMIT_OVERRIDE

@lukasmetzner
refactor: Switched to k8s.io/mount-utils
8147b51 
Replaced our code for formatting and other disk related functions to k8s.io/mount-utils. This leaves only code that is related to LUKS.
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.88%. Comparing base (f908f5d) to head (7f98cea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/volumes/mount.go 0.00% 6 Missing ⚠️
internal/mock/volume.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   34.54%   35.88%   +1.34%     
==========================================
  Files          19       19              
  Lines        1621     1853     +232     
==========================================
+ Hits          560      665     +105     
- Misses       1027     1154     +127     
  Partials       34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasmetzner lukasmetzner marked this pull request as ready for review October 17, 2024 13:22
@lukasmetzner lukasmetzner requested a review from a team as a code owner October 17, 2024 13:22
@lukasmetzner lukasmetzner self-assigned this Oct 18, 2024
jooola
jooola approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side 🚀

@jooola
Copy link
Member

jooola commented Oct 18, 2024

Note that this change opens up the possibility to format the disk with almost any file system (mkfs.*), maybe the docs should be updated?

@apricote
Copy link
Member

apricote commented Oct 18, 2024 •
edited
Loading

Note that this change opens up the possibility to format the disk with almost any file system (mkfs.*), maybe the docs should be updated?

Looking at k8s.io/mount-utils.SafeFormatAndMount.formatAndMountSensitive it looks like it only supports ext4,ext3 and zfs. Right now we also support btrfs, so this would break current functionality :(

They add additional args for the fs, but everything is theoretically supported.

@lukasmetzner @apricote
Update test/integration/integration_test.go
7f98cea 
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
@lukasmetzner lukasmetzner merged commit 173bf2f into main Oct 18, 2024
8 checks passed
@lukasmetzner lukasmetzner deleted the refactor-mount-utils branch October 18, 2024 10:55
@hcloud-bot hcloud-bot mentioned this pull request Oct 23, 2024
Merged
lukasmetzner pushed a commit that referenced this pull request Oct 29, 2024
@hcloud-bot
chore(main): release 2.10.0 (#723)
7bf5096 
🤖 I have created a release *beep* *boop*
---


##
[2.10.0](v2.9.0...v2.10.0)
(2024-10-29)


### Features

* add support & tests for Kubernetes 1.31
([#721](#721))
([85035b9](85035b9))
* allow arbitrary length API tokens
([#724](#724))
([61c3a0e](61c3a0e))
* allow passing mkfs format options via storage class parameters
([#747](#747))
([4b9aa4e](4b9aa4e))
* change XFS default options to support older kernels
([#747](#747))
([4b9aa4e](4b9aa4e))
* drop tests for Kubernetes 1.27
([#722](#722))
([d46a54b](d46a54b))
* force pods with volumes to be scheduled on Cloud servers
([#743](#743))
([702fe01](702fe01))
* fstype is directly passed to mkfs: mkfs.&lt;fstype&gt;
([#749](#749))
([173bf2f](173bf2f))
* support for SELinux mount
([#756](#756))
([719247e](719247e)),
closes [#582](#582)
* Support SINGLE_NODE_MULTI_WRITER capability
([#725](#725))
([cd53c23](cd53c23)),
closes [#327](#327)
* **swarm:** removed workaround support for mock staging/unstaging
([#746](#746))
([465ec21](465ec21))


### Bug Fixes

* do not log sensitive mount options
([#755](#755))
([0b6e860](0b6e860))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
lukasmetzner pushed a commit that referenced this pull request Nov 11, 2024
@hcloud-bot @lukasmetzner
chore(main): release 2.10.0 (#723)
1951756 
🤖 I have created a release *beep* *boop*
---


##
[2.10.0](v2.9.0...v2.10.0)
(2024-10-29)


### Features

* add support & tests for Kubernetes 1.31
([#721](#721))
([85035b9](85035b9))
* allow arbitrary length API tokens
([#724](#724))
([61c3a0e](61c3a0e))
* allow passing mkfs format options via storage class parameters
([#747](#747))
([4b9aa4e](4b9aa4e))
* change XFS default options to support older kernels
([#747](#747))
([4b9aa4e](4b9aa4e))
* drop tests for Kubernetes 1.27
([#722](#722))
([d46a54b](d46a54b))
* force pods with volumes to be scheduled on Cloud servers
([#743](#743))
([702fe01](702fe01))
* fstype is directly passed to mkfs: mkfs.&lt;fstype&gt;
([#749](#749))
([173bf2f](173bf2f))
* support for SELinux mount
([#756](#756))
([719247e](719247e)),
closes [#582](#582)
* Support SINGLE_NODE_MULTI_WRITER capability
([#725](#725))
([cd53c23](cd53c23)),
closes [#327](#327)
* **swarm:** removed workaround support for mock staging/unstaging
([#746](#746))
([465ec21](465ec21))


### Bug Fixes

* do not log sensitive mount options
([#755](#755))
([0b6e860](0b6e860))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote left review comments

@jooola jooola jooola approved these changes

Assignees

@lukasmetzner lukasmetzner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasmetzner @jooola @apricote