fix: prefer scheduling the csi controller on cloud nodes #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a partial fix, but in clusters where the `instance.hetzner.cloud/provided-by` label is present and set accordingly for cloud nodes it prevents the controller from being scheduled on non cloud nodes. We need this, as in our default behavior for fetching the default volume location we rely on the node name being a Hetzner cloud server.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 35.85% 35.85%
=======================================
Files 20 20
Lines 1874 1874
=======================================
Hits 672 672
Misses 1168 1168
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
apricote
changed the title
apricote
approved these changes
Nov 21, 2024
lukasmetzner
pushed a commit
that referenced
this pull request
Nov 26, 2024
<!-- section-start changelog --> ### Features - Added new option enableProvidedByTopology (#780) - drop tests for kubernetes v1.28 (#796) ### Bug Fixes - prefer scheduling the csi controller on cloud nodes (#786) ### Kubernetes Support This version was tested with Kubernetes 1.29 - 1.31. Furthermore, we dropped v1.28 support. <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ### Kubernetes Support This version was tested with Kubernetes 1.29 - 1.31. Furthermore, we dropped v1.28 support. ``` </details> Co-authored-by: releaser-pleaser <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a partial fix, but in clusters where the
instance.hetzner.cloud/provided-bylabel is present and set accordingly for cloud nodes it prevents the controller from being scheduled on non cloud nodes. We need this, as in our default behavior for fetching the default volume location we rely on the node name being a Hetzner cloud.