Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server labels as node labels #41

Closed
cubic3d opened this issue May 5, 2020 · 6 comments
Closed

Add server labels as node labels #41

cubic3d opened this issue May 5, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed pinned

Comments

@cubic3d
Copy link

cubic3d commented May 5, 2020

It would be quite nice to have server labels from Hetzner to be set as node labels by the controller.
Would be then possible to provision servers by e.g. Terraform as workers with cloud-init and cluster join parameters and have labels available for scheduling selection after node initialization.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2020

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Jun 5, 2020
@cubic3d
Copy link
Author

cubic3d commented Jun 5, 2020

Still useful? =/

@LKaemmerling
Copy link
Member

Hey,

actually we have a few problems with this, as we don't have access to the node labels (or annotations) directly, so we would need to query the k8s API for this. We will look further into this in the future.

@fhofherr could you please look into this?

@LKaemmerling LKaemmerling removed the stale label Jun 5, 2020
@LKaemmerling
Copy link
Member

@cubic3d i did a bit of research here. Using the k8s labels for this is quite a bit annoying i would favor using annotations here (so we fill annotations with the labels). Do you think a "2 way sync" (Labels from k8s into the hcloud) would also help?

@cubic3d
Copy link
Author

cubic3d commented Jul 1, 2020

@LKaemmerling annotations are non-identifiable attributes in the k8s world, this would not allow to use them in probably most useful situations like with nodeSelector to create pod to node preferences.

2-way-sync would probably be beneficial for in-cluster apps running automation tasks and probably relabel or remove.

@github-actions github-actions bot added the stale label Jul 31, 2020
@hetznercloud hetznercloud deleted a comment from github-actions bot Jul 31, 2020
@LKaemmerling LKaemmerling added pinned and removed stale labels Jul 31, 2020
@LKaemmerling LKaemmerling added enhancement New feature or request help wanted Extra attention is needed labels Aug 25, 2020
@LKaemmerling
Copy link
Member

We decided to not implement it, because it doesn't fit with the cloud controller spec from k8s.

apricote pushed a commit that referenced this issue Sep 2, 2024
* 🌱 enable robot api debug, only if ROBOT_DEBUG is set.

* ... more explicit log message, and explicit default of "false" in yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

2 participants