-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server labels as node labels #41
Comments
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
Still useful? =/ |
Hey, actually we have a few problems with this, as we don't have access to the node labels (or annotations) directly, so we would need to query the k8s API for this. We will look further into this in the future. @fhofherr could you please look into this? |
@cubic3d i did a bit of research here. Using the k8s labels for this is quite a bit annoying i would favor using annotations here (so we fill annotations with the labels). Do you think a "2 way sync" (Labels from k8s into the hcloud) would also help? |
@LKaemmerling annotations are non-identifiable attributes in the k8s world, this would not allow to use them in probably most useful situations like with 2-way-sync would probably be beneficial for in-cluster apps running automation tasks and probably relabel or remove. |
We decided to not implement it, because it doesn't fit with the cloud controller spec from k8s. |
* 🌱 enable robot api debug, only if ROBOT_DEBUG is set. * ... more explicit log message, and explicit default of "false" in yaml.
It would be quite nice to have server labels from Hetzner to be set as node labels by the controller.
Would be then possible to provision servers by e.g. Terraform as workers with cloud-init and cluster join parameters and have labels available for scheduling selection after node initialization.
The text was updated successfully, but these errors were encountered: