feat(metrics): add metrics from cloud-provider library #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes metrics about internal operations from `k8s.io/cloud-provider` like the workqueue depth and requests to the Kubernetes API. This metrics were already exposed on `:8233/metrics` but this was not documented or scraped. This commit now uses the same registry for our metrics and the kubernetes libraries, and also exposes them on both ports for backwards compatibility. Co-authored-by: Lukas Metzner <lukas.metzner@hetzner-cloud.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 70.56% 70.56% -0.01%
==========================================
Files 31 31
Lines 3289 3285 -4
==========================================
- Hits 2321 2318 -3
+ Misses 794 793 -1
Partials 174 174 ☔ View full report in Codecov by Sentry. |
apricote
force-pushed
the
kubernetes-metrics
branch
from
86fdae8 to
e8a555b
Compare
lukasmetzner
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes metrics about internal operations from
k8s.io/cloud-providerlike the workqueue depth and requests to the Kubernetes API.This metrics were already exposed on
:8233/metricsbut this was not documented or scraped.This commit now uses the same registry for our metrics and the Kubernetes libraries, and also exposes them on both ports for backwards compatibility.
Besides having all data available, this will also help us with debugging #661.