ci: added golangci-lint to pre-commit #829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added golangci-lint run hook to pre-commit configuration and removed separate CI step.
lukasmetzner
had a problem deploying
to
e2e-robot
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 70.56% 70.56%
=======================================
Files 31 31
Lines 3285 3285
=======================================
Hits 2318 2318
Misses 793 793
Partials 174 174 ☔ View full report in Codecov by Sentry. |
Pin golangci-lint language version and let it manage via renovate
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
jooola
reviewed
Dec 17, 2024
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
lukasmetzner
had a problem deploying
to
e2e-robot
GitHub Actions
Error
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
jooola
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
I would just check how long the cold run takes and see if the cache is persisted across ci runs, if not we might need to investigate why the cache is not preserved.
Other than that looks good from my side, maybe @apricote is against this, I'll leave the final decision to him.
jooola
reviewed
Dec 17, 2024
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
had a problem deploying
to
e2e-robot
GitHub Actions
Failure
jooola
reviewed
Dec 17, 2024
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
Additionally include restore-keys.
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
golangci-lint has by far the longest runtime and should therefore be executed last.
apricote
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added golangci-lint run hook to pre-commit configuration and removed separate CI step.