Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server public ipv4 and ipv6 properties are nullable #455

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Oct 21, 2024

Fix the incorrect typing that was caught in #454

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (ce2b336) to head (f8ca535).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          64       64           
  Lines        2981     2981           
=======================================
  Hits         2768     2768           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit d2cfee6 into main Oct 21, 2024
11 checks passed
@jooola jooola deleted the server-public-net branch October 21, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants