Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Tutorial for an soketi-server (WebSocket-Server) behind a Reverse Proxy (nginx) #894

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

crocodile2024
Copy link
Contributor

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: crocodile2024 < crocodile202405@gmail.com>

@svenja11
Copy link
Collaborator

svenja11 commented Aug 5, 2024

Thank you for your contribution @crocodile2024!

Please note the following contribution guidelines:

If you're fluent in another language, and are able to make a translation, you can submit your tutorial in multiple languages, as long as at least one of them is English.

Before I review your tutorial, could you please confirm if you plan to add the English version too?

@crocodile2024
Copy link
Contributor Author

crocodile2024 commented Aug 5, 2024 via email

@svenja11 svenja11 added the review wanted Request a review label Aug 5, 2024
@vdbhb59
Copy link

vdbhb59 commented Aug 6, 2024

I can translate the above one to English and give it over here. Will that make me a contributor, or.. ?

@svenja11
Copy link
Collaborator

svenja11 commented Aug 7, 2024

Generally, we do accept translations, but translations are a lot easier to produce and far less time-consuming than actually writing a tutorial and are treated as such.

Please also note that @crocodile2024 already confirmed that they will contribute the English translation for this tutorial.

@crocodile2024
Copy link
Contributor Author

Hello,
i have added an english version.

@svenja11
Copy link
Collaborator

I read through your tutorial and I made some minor changes:

  • With new tutorials, we want to use "Du" instead of "Sie", so I updated the German text accordingly.
  • When I used the command apt install nodejs, it automatically installed a version that is not supported by Soketi, so I changed the installation process of NodeJS to install a supported version.
  • I moved the DNS entries down to the step about SSL certificates.
  • Everyone should be able to follow the tutorial, so I added some quick installation steps for Laravel in case someone doesn't have it installed yet.

Please let me know if the changes I made are fine with you. If they are, please add the license block at the bottom of both files (01.en.md & 01.de.md) and I will mark this PR as ready:

Remember to replace [submitter's name and email address here] with your own information.

##### License: MIT

<!--

Contributor's Certificate of Origin

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have
    the right to submit it under the license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my
    knowledge, is covered under an appropriate license and I have the
    right under that license to submit that work with modifications,
    whether created in whole or in part by me, under the same license
    (unless I am permitted to submit under a different license), as
    indicated in the file; or

(c) The contribution was provided directly to me by some other person
    who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are
    public and that a record of the contribution (including all personal
    information I submit with it, including my sign-off) is maintained
    indefinitely and may be redistributed consistent with this project
    or the license(s) involved.

Signed-off-by: [submitter's name and email address here]

-->

@svenja11 svenja11 added needs action Something has to be updated and removed review wanted Request a review labels Aug 13, 2024
@svenja11 svenja11 added ready and removed needs action Something has to be updated labels Aug 19, 2024
@svenja11 svenja11 merged commit c29cde1 into hetzneronline:master Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants