Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-nodejs-with-docker tutorial #936

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

matteocontrini
Copy link
Contributor

As dicussed in #932, here's the updated tutorial.

A couple of things to decide on:

  • Whether the tutorial date should be change to today, or if there's an "updated at" field that could be used to signal that the tutorial is up-to-date.
  • Whether the automated builds section should be removed or updated, since that Docker Hub feature is no longer free and requires a paid subscription.

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: Matteo Contrini matteo@contrini.it

@svenja11 svenja11 added ready Existing tutorial Changes on an existing tutorial labels Sep 5, 2024
@svenja11
Copy link
Collaborator

svenja11 commented Sep 5, 2024

Thank you for taking the time to update your tutorial @matteocontrini!

  • We don't have an "updated" field, so we usually just update the "date" field.
  • Thank you for pointing that out. I removed the "automated builds" section but I did add a link to docker.docs » Set up Automated Builds. This should be enough.

I also added a small Node.js example so that anyone can follow the tutorial, even if they don't have a Node.js application ready yet.

@svenja11 svenja11 merged commit c2d8a08 into hetzneronline:master Sep 5, 2024
2 checks passed
@matteocontrini
Copy link
Contributor Author

Thanks. I think you also need to:

  • Remove or adapt this sentence referring to automated builds in the conclusions:

Setting up automated builds is useful and a first step into the Continuous Integration and Delivery world (CI/CD).

  • Remove the images folder, which contains Docker Hub screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing tutorial Changes on an existing tutorial ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants