PlatformPlayer: Attempt to load audio files with empty contentType #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "Gangstar Rio - City of Saints", it appears this empty type is actually used by WAV files, so let's try opening streams that come with those empty strings, they might contain one of the supported media formats. As opposed to printing "No player for: " on the console, Gangstar Rio now plays SFX correctly. Jurassic Park on the other hand, fails to open its very first audio stream as either MIDI or WAV.
Since we will manually try to load streams without an explicit type as one of the supported formats, opening a midi stream is now far more likely to fail, so account for that and close the Sequencer whenever that is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Refer to that issue for more in-depth info. This one is rather rare, but there are apps which do indeed pass an audio stream to FreeJ2ME without providing its type, so we have to manually try and load them as one of the supported formats.