Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lease.pm: Remove Bool type check and replace with Any. #63

Merged
merged 3 commits into from
Oct 13, 2018
Merged

Lease.pm: Remove Bool type check and replace with Any. #63

merged 3 commits into from
Oct 13, 2018

Conversation

hexfusion
Copy link
Owner

Fixes #59

@hexfusion
Actions.pm: add retry_auth to list of keys to omit.
7e6b625
@hexfusion
Lease.pm: Remove Bool type check and replace with Any.
66d85fa 
resolves errors such as :
Reference bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ) did not pass type constraint "Bool" (in $args->{"keys"})

For now the failure is not worth the type check but I am unsure why JSON
expands the bool here. I can not replicate locally but Travis reports
this every run.
@hexfusion
Update Changelog to reflect bugfix.
68fff5f
@hexfusion hexfusion merged commit 697a08b into master Oct 13, 2018
@hexfusion hexfusion deleted the fx_bugs branch October 13, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hexfusion