Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace travis with github actions #83

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

curbengh
Copy link
Contributor

No description provided.

@curbengh
Copy link
Contributor Author

curbengh commented Jul 24, 2020

@yoshinorin github actions not enabled for this repo?

@yoshinorin
Copy link
Member

@yoshinorin github actions not enabled for this repo?

No. It is enabled.
It seems same with https://github.com/hexojs/hexo. 🤔

@yoshinorin
Copy link
Member

@segayuu
We adding GitHubAction to this repo.

The settings seem the same with https://github.com/hexojs/hexo
But, not triggered.

You added GitHubAction to hexo repo. Do you come up with what is a problem?

hexojs/hexo#4169

@curbengh
Copy link
Contributor Author

curbengh commented Jul 30, 2020

@yoshinorin
It's triggered now after I push to upstream branch and compare changes (without actually create a PR).

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories
Workflows do not run on private base repositories when you open a pull request from a forked repository.

🤔 my fork is not private and it did trigger on hexo-filter-follow when I create PR from my forked branch. anyway, looks like creating upstream branch solved it.

@curbengh curbengh merged commit 881f860 into hexojs:master Jul 30, 2020
@curbengh curbengh deleted the gh-action branch July 30, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants