Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(decodeURL): update to whatwg api #117

Merged
merged 1 commit into from
Nov 2, 2019
Merged

refactor(decodeURL): update to whatwg api #117

merged 1 commit into from
Nov 2, 2019

Conversation

curbengh
Copy link
Contributor

Continuation of #114

Node 8's url.format() doesn't support port number, so a workaround is used instead.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 95.286% when pulling a188b58 on curbengh:whatwg-decodeurl into 635161b on hexojs:master.

@curbengh curbengh requested review from a team and removed request for a team October 28, 2019 02:57
@curbengh
Copy link
Contributor Author

curbengh commented Nov 2, 2019

Ready for review.

@curbengh curbengh merged commit fb02cc9 into hexojs:master Nov 2, 2019
@curbengh curbengh deleted the whatwg-decodeurl branch November 2, 2019 01:36
@curbengh curbengh mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW