refactor(strip_html): remove striptags deps #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
striptags
is the most safe strip HTML lib (as it implements a AST parser instead of using regex).However:
striptags
implements a simple Symbol polyfill that Hexo doesn't need (we target latest Node.js LTS)striptags
supports stream and many other features (like tags whitelist) that Hexo doesn't need as wellstriptags
introduce a bit performance drawback.The PR re-implements the
striptags
without those unneeded features. The unit test cases are adopted fromstriptags
.