Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build OTP 27 #190

Merged
merged 1 commit into from
May 21, 2024
Merged

Build OTP 27 #190

merged 1 commit into from
May 21, 2024

Conversation

rodrigues
Copy link
Contributor

Hi there 👋

Possibly still too early for this?

Thanks!

@rodrigues rodrigues closed this May 20, 2024
@rodrigues rodrigues deleted the otp_27 branch May 20, 2024 21:01
@ericmj
Copy link
Member

ericmj commented May 20, 2024 •
edited
Loading

@rodrigues Your PR looks good with the change José suggested. Would you mind reopening?

EDIT: When Elixir 1.17 ships we will start to automatically build it against OTP 27.

@rodrigues
Copy link
Contributor Author

@ericmj sure thing!

@rodrigues rodrigues restored the otp_27 branch May 20, 2024 21:04
@rodrigues
Copy link
Contributor Author

reopen

@rodrigues rodrigues reopened this May 20, 2024
rodrigues
rodrigues commented May 21, 2024
View reviewed changes
lib/bob/job/build_elixir.ex
@@ -16,6 +16,7 @@ defmodule Bob.Job.BuildElixir do
version = ref_to_version(ref_name)

cond do
version_gte(version, "1.17.0-0") -> ["25.3", "26.0", "27.0"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if I should put 1.17.0-rc.0 instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work

@ericmj ericmj merged commit 7833618 into hexpm:main May 21, 2024
2 checks passed
@ericmj
Copy link
Member

ericmj commented May 21, 2024

Thank you!

@rodrigues rodrigues deleted the otp_27 branch May 21, 2024 07:36
@inoas-nbw
Copy link

Thank you so much

@inoas-nbw
Copy link

Does this also fix building elixir 1.16.x against OTP 27.0?

@inoas-nbw
Copy link

ref https://github.com/hexpm/bob/blob/main/lib/bob/job/build_elixir.ex#L19-L20

@ericmj
Copy link
Member

ericmj commented May 21, 2024

No, they are not compatible https://hexdocs.pm/elixir/main/compatibility-and-deprecations.html#between-elixir-and-erlang-otp.

Elixir 1.17 RC will be released soon which is compatible with OTP 27.

@inoas-nbw
Copy link

Thanks, excuse the noise!

@rodrigues
Copy link
Contributor Author

@ericmj elixir 1.17.0-rc.0 is not building with latest OTP 27, it picked just 27.0-rc1, something we should change here?

thanks!

Screenshot 2024-05-24 at 18 30 30

@ericmj
Copy link
Member

ericmj commented May 24, 2024

The docker builds are derived from DockerChecker, not this job.

@rodrigues
Copy link
Contributor Author

@ericmj thanks! tried to understand a bit, I think the problem is that we're not building hexpm/erlang/27.0 (rc1 is built though), therefore docker checker doesn't pick it up

@ericmj
Copy link
Member

ericmj commented May 25, 2024

@rodrigues Bad sorting caused the dedup check to work incorrectly. We are building OTP 27.0 now.

28d2bac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj ericmj left review comments

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigues @ericmj @inoas-nbw @josevalim