Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring 18 emojis from openmoji-xk-extensions (November 2023) #479

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

xavizardKnight
Copy link
Contributor

Heyas! This is the PR for transferring 18 emojis from my openmoji-xk-extensions repo to here, as debated in issue #475.

The emojis included here are:

  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0076-E0063-E007F.svg (Valencian Community ES-VC)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0069-E0062-E007F.svg (Balearic Islands ES-IB)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0061-E0072-E007F.svg (Aragon ES-AR)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E006D-E0063-E007F.svg (Murcia ES-MC)
  • extras-openmoji/objects/E14A.svg (Motorbike helmet)
  • extras-openmoji/objects/E145.svg (Guy Fawkes mask)
  • extras-openmoji/brand/E062.svg (C programming language logo)
  • extras-openmoji/brand/E063.svg (C++ programming language logo)
  • extras-openmoji/brand/E064.svg (C# programming language logo)
  • extras-openmoji/brand/E065.svg (Chrome Canary logo)
  • extras-openmoji/brand/E066.svg (Firefox Developer logo)
  • extras-openmoji/brand/E067.svg (Firefox Canary logo)
  • extras-openmoji/brand/E068.svg (JavaScript programming language logo)
  • extras-openmoji/brand/E069.svg (TypeScript programming language logo)
  • extras-openmoji/brand/E06A.svg (WebAssembly logo)
  • extras-openmoji/brand/E06B.svg (SVG logo)
  • extras-openmoji/brand/E06C.svg (Markdown logo)
  • extras-openmoji/brand/E06D.svg (WinRAR logo)

On top of finally fixing the motorbike helmet dark mode outline problem, here are a few more things that have been changed in these emojis since I opened the issue 2 weeks ago:

  • Made the SVG icon smaller so it fits into the grid.
  • Tweaked the WebAssembly emoji, so the dark mode outline is less weird at the corners of the top indent.
  • Made the “nose-lines” of the guy-fawkes-mask be black and into the line layer, so the outlined version looks better.
  • Made the M and the down arrow of the Markdown emoji slightly smaller to make the emoji less messy on smaller sizes.
  • Fixed a weird pink spike in the hexagon corners of the csharp logo.
  • Modified the blue square in the Balearic Islands flag, so the dark mode outline doesn't do a weird bump at the top left corner of the flag.

Merging this PR will close issue #475.

Issue #468 could also be closed, but I don't know if there are other programming language icons left to add (excepting the ones that currently cannot be added due to attribution requirements, like the Ruby icon or the HTML shields).

This PR also implements a few more Spain subdivision flags that issue #416 suggested; nevertheless not all the subdivision flags are done, and a few are still missing (I want to make more of them soon, I'll post a new PR once those are done, alongside some US subdivision flags I also have work-in-progress).

Thank you and have a nice day!

@xavizardKnight xavizardKnight marked this pull request as ready for review December 5, 2023 16:18
@b-g b-g merged commit d9f5387 into hfg-gmuend:master Dec 6, 2023
1 check passed
@b-g
Copy link
Member

b-g commented Dec 6, 2023

@xavizardKnight Many many thanks for this! Mega! Merged + added to changelog.txt

One last thing: As you've contributed quite a lot ... I was wondering whether you want to be listed under https://openmoji.org/about/#authors--team? If so, please provide a portrait image :)

@xavizardKnight
Copy link
Contributor Author

Thanks for merging!

One last thing: As you've contributed quite a lot ... I was wondering whether you want to be listed under openmoji.org/about/#authors--team? If so, please provide a portrait image :)

Yeah, sure. How do we do it? I create an SVG of myself in OpenMoji style, or do I send you a picture of me and you create it?

@b-g
Copy link
Member

b-g commented Dec 7, 2023

Yes. Either post your portrait image and links at https://github.com/hfg-gmuend/openmoji.org/issues or via a PR in that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants