Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Pandas 1.5/1.6 #133

Merged
merged 31 commits into from
Oct 27, 2022
Merged

Support for Pandas 1.5/1.6 #133

merged 31 commits into from
Oct 27, 2022

Conversation

andrewgsavage
Copy link
Collaborator

@andrewgsavage andrewgsavage commented Oct 1, 2022

Probably closes #120

This is running locally, with hgrecco/pint#1596. Quite a few additional tests passing!
This is following the change to is_list_like in pandas, so allows constrcutors and setitem to work.

@andrewgsavage
Copy link
Collaborator Author

I've pointed this to my pint branch which adds ndim for Quantity, and my pandas branch which changes makes assert...equal recognise pint Quantitys as scalar. This is down to
=========== 489 passed, 11 xfailed, 7 xpassed, 6 warnings in 11.20s ============
It was previously
========== 433 passed, 64 xfailed, 8 xpassed, 246 warnings in 24.09s ===========

@andrewgsavage
Copy link
Collaborator Author

That's all the tests working with, the exception of the ones xfailed in pandas!

@andrewgsavage andrewgsavage changed the title Support for Pandas 1.5 Support for Pandas 1.6 Oct 8, 2022
@andrewgsavage andrewgsavage mentioned this pull request Oct 8, 2022
7 tasks
MichaelTiemannOSC added a commit to MichaelTiemannOSC/pint-pandas that referenced this pull request Oct 15, 2022
Signed-off-by: MichaelTiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
@andrewgsavage
Copy link
Collaborator Author

some issue with python 3.11 installing pyarrow so I'll leave that out for another PR.

@andrewgsavage andrewgsavage changed the title Support for Pandas 1.6 Support for Pandas 1.5/1.6 Oct 26, 2022
@andrewgsavage
Copy link
Collaborator Author

This is ready now. @hgrecco Could you take a look at it?

I have set it to use my fork of pandas with branches for 1.5.x and 1.6.x to get around the assert_series_equal issue (pint scalars are recognised as iterable in a testing function). I've got a pandas issue and PR for this.

Is it better to have the affected tests xpassed, or to use my branches?
I'm leaning towards using my branches as this lets us run these tests and know if any changes cause behaviour to change.

@hgrecco
Copy link
Owner

hgrecco commented Oct 27, 2022

I have review it and I like the code. Should I release a new pint-pandas version now?

I agree that you should use your branches for testing

@andrewgsavage
Copy link
Collaborator Author

OK great, I'll merge this and #132 and then you can release a new version.

@andrewgsavage
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnitStrippedWarning, simple case Experimental status?
2 participants