-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Pandas 1.5/1.6 #133
Conversation
…pandas_1.5 Merge split tests
I've pointed this to my pint branch which adds ndim for Quantity, and my pandas branch which changes makes assert...equal recognise pint Quantitys as scalar. This is down to |
That's all the tests working with, the exception of the ones xfailed in pandas! |
Signed-off-by: MichaelTiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
some issue with python 3.11 installing pyarrow so I'll leave that out for another PR. |
This is ready now. @hgrecco Could you take a look at it? I have set it to use my fork of pandas with branches for 1.5.x and 1.6.x to get around the assert_series_equal issue (pint scalars are recognised as iterable in a testing function). I've got a pandas issue and PR for this. Is it better to have the affected tests xpassed, or to use my branches? |
I have review it and I like the code. Should I release a new pint-pandas version now? I agree that you should use your branches for testing |
OK great, I'll merge this and #132 and then you can release a new version. |
bors r+ |
dtype
#117 Trouble using Quantity to extend existing DataFrame #113 TypeError using DataFrame.mask #93 TypeError: object of type 'numpy.float64' has no len() #26pre-commit run --all-files
with no errorsProbably closes #120
This is running locally, with hgrecco/pint#1596. Quite a few additional tests passing!
This is following the change to is_list_like in pandas, so allows constrcutors and setitem to work.