-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/137 compat check #245
Pr/137 compat check #245
Conversation
PR number 137 adds _get_common_dtype to PintType so that `PintType` operations can be performed on a mix of `PintType` and numeric values (with the later being promoted to the `PintType` for the purposes of the operation). However, when there are multiple `PintType` elements present, it is important that all elements are in fact compatible, lest the operation attempt to combine two `PintType` elements that are not unit-compatible.
Clean up PR for submission.
It appears that the new compatibility check prevents the eval function from operating as expected under Pandas 3.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to file an issue for this problem, glad to see it is already being addressed 🙇
This code used to work, but now fails:
The Note that if we allow |
@MichaelTiemannOSC I do not quite understand how you code used to work since it tries to mix |
A pandas data frame can collect heterogenous types. They won't be proper |
PR number 137 adds _get_common_dtype to PintType so that
PintType
operations can be performed on a mix ofPintType
and numeric values (with the later being promoted to thePintType
for the purposes of the operation). However, when there are multiplePintType
elements present, it is important that all elements are in fact compatible, lest the operation attempt to combine twoPintType
elements that are not unit-compatible.pre-commit run --all-files
with no errors