[WIP] Convert object dtype #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
readu for review |
CHANGES
Outdated
| @@ -6,6 +6,7 @@ pint-pandas Changelog | |||
|
|
|||
| - Support for <NA> values in columns with integer magnitudes | |||
| - Support for magnitudes of any type, such as complex128 or tuples #146 | |||
| - A DataFrame/Series.pint.convert_object_dtype() function has been added to create PintArrays from Series of quantitys. | |||
There was a problem hiding this comment.
typo: quantitys to quantities
| @staticmethod | ||
| def _is_object_dtype_and_quantity(obj): | ||
| return obj.dtype == "object" and all( | ||
| [(isinstance(item, _Quantity) or pd.isna(item)) for item in obj.values] |
There was a problem hiding this comment.
Does this play well with uncertainties?
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #55