Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict between hour and Planck's constant #82

Closed
choloepus opened this issue Dec 28, 2013 · 1 comment
Closed

Name conflict between hour and Planck's constant #82

choloepus opened this issue Dec 28, 2013 · 1 comment
Labels

Comments

@choloepus
Copy link
Contributor

constants_en.txt defines "h" as Planck's constant, but default_en.txt defines "h" as hour. The result is that ureg.h ends up as the hour.

I would recommend removing "h" from default_en.txt, since "hr" and "hour" are pretty good names for the hour, but "planck_constant" is rather unwieldy and there is no other widely used abbreviation.

This line of default_en.txt is also used as an example in the documentation on the "Defining units" page, so it should be changed there as well if default_en.txt is changed.

@hgrecco
Copy link
Owner

hgrecco commented Dec 28, 2013

Agreed. I will change this soon.

matze pushed a commit to ufo-kit/concert that referenced this issue Apr 16, 2014
Pint changed h to Planck's constant in version 0.4.2, see:
hgrecco/pint#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants