-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add np.linalg.norm implementation #1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but someone with the permissions would have to rerun the tests so we can investigate the failures (the logs have expired since then).
I've managed to come back to this PR after quite a while. As such, I've updated the PR by merging upstream changes and addressed the previous feedback. The actions on the forked repository (here) appear to be passing, but I'm otherwise not sure why the PR workflows here are failing. |
We are using Pint and |
@arjavtrivedi (or @hgrecco / @jules-ch), could you merge in |
CodSpeed Performance ReportMerging #1251 will improve performances by 20.16%Comparing Summary
Benchmarks breakdown
|
@keewis |
Thanks @arjavtrivedi !! |
Thank you @hgrecco for the great software! |
This is not important anymore since the PR was merged (but I guess is good to know for any future PRs). Still, what I meant was to merge |
@keewis I think that the current master has everything ok, right? |
yep, it was just that on this PR RTD failed because the configuration still contained the |
Ready for review:
pre-commit run --all-files
with no errorsDoc entry in docs/numpy.ipynb already covered by print statement here: