Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement numpy.nanprod #1369

Merged
merged 11 commits into from
Feb 2, 2022
Merged

implement numpy.nanprod #1369

merged 11 commits into from
Feb 2, 2022

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Aug 8, 2021

This is one of the remaining functions used by xarray that are still missing.

  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate documentation is automatic
  • Added an entry to the CHANGES file

@hgrecco
Copy link
Owner

hgrecco commented Aug 19, 2021

Looks good to me

@keewis keewis mentioned this pull request Jan 16, 2022
Closed
21 tasks
@jules-ch
Copy link
Collaborator

@keewis can you move CHANGES to last version. And I can merge this PR

@jules-ch jules-ch merged commit f1dc122 into hgrecco:master Feb 2, 2022
@keewis keewis deleted the nanprod branch February 10, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @hgrecco @jules-ch