-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutating the application registry #1403
Conversation
I'm not sure if that was a random failure on RTD, but pinning |
I've explained the error in RTD build here #1399 (comment). Looks good to me. |
great. Should I add a note to |
oh, and is it fine to keep the pin in this PR? |
Yes Add this fix in CHANGES & keep the pin I'll pin other docs dependencies in another PR. |
done |
Thanks @keewis |
* check that mutations are propagated * define __setattr__ on the ApplicationRegistry class * try pinning sphinx [skip ci] * update CHANGES [skip ci]
When adding the
ApplicationRegistry
class I apparently forgot to forward__setattr__
. This means that trying to mutate the application registry does not change the wrapped registry, but rather adds a new attribute toApplicationRegistry
:Since this is included in
v0.18
, we might need a new release soon. What do you think, @hgrecco, @jules-chpre-commit run --all-files
with no errors