Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of offset units for higher dimensional units (e.g. gauge pressure #1066) #1409

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

dalito
Copy link
Contributor

@dalito dalito commented Nov 6, 2021

  • Closes Absolute vs. Relative pressure #1066
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

The problem was limited to offset units of higher dimension like pressure (M L-1 T-2). The offset units included in pint are all temperature units with just one dimension and were thus not affected.

@dalito dalito changed the title Fix use of offset units fo defining gauge pressure. #1066 Fix use of offset units for defining gauge pressure. #1066 Nov 6, 2021
@dalito dalito changed the title Fix use of offset units for defining gauge pressure. #1066 Fix use of offset units for higher dimensional units (e.g. gauge pressure #1066) Nov 6, 2021
@dalito dalito mentioned this pull request Jan 16, 2022
21 tasks
@jules-ch
Copy link
Collaborator

jules-ch commented Feb 2, 2022

@dalito can you rebase & push to resolve conflict on changes

@jules-ch
Copy link
Collaborator

jules-ch commented Feb 3, 2022

Great, merging this.
Thanks @dalito

@jules-ch jules-ch merged commit 8532f77 into hgrecco:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute vs. Relative pressure
2 participants