Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define microns as 1e-6 m #1434

Closed
wants to merge 1 commit into from
Closed

Conversation

clbarnes
Copy link
Contributor

@clbarnes clbarnes commented Dec 9, 2021

This resolves #1433, the non-equality with micrometers.
Also includes a test which previously failed and now passes.

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

This resolves hgrecco#1433, the non-equality with micrometers.
Also includes a test which previously failed and now passes.
@clbarnes clbarnes marked this pull request as ready for review December 9, 2021 12:14
@clbarnes
Copy link
Contributor Author

clbarnes commented Dec 9, 2021

This passes locally. However, I did find that I had to pip install the package again every time I changed the definitions file, even when the package was installed in editable mode. Without doing that, the test would pass in VScode, but fail when I called pytest (even in the terminal within VScode). This may be due to how package data files are handled, and this failure may relate to that by way of the pip cache.

@jules-ch
Copy link
Collaborator

jules-ch commented Dec 9, 2021

We're install pint before testing with pip install ., I'll look into it.

@dalito
Copy link
Contributor

dalito commented Dec 9, 2021

I just tried this in a standard console (cmder/cmd on Win10). There it is not necessary to reinstall pint after changing the default registry file (default_en.txt). May it be related to VScode? A colleague had a somewhat similar problem with terminals in VScode this week.
Sorry, I initially misunderstood what you wrote.

@clbarnes
Copy link
Contributor Author

clbarnes commented Apr 4, 2022

I believe this can be closed now that #1476 has been merged.

@hgrecco
Copy link
Owner

hgrecco commented Apr 25, 2023

Yes, but I am anyway keeping part of the test.

@hgrecco hgrecco closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically alias definitions where 1 X = 1 Y, and hash-equivalent aliases
4 participants