Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse inf and nan in Quantity #1435

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Parse inf and nan in Quantity #1435

merged 1 commit into from
Dec 9, 2021

Conversation

clbarnes
Copy link
Contributor

@clbarnes clbarnes commented Dec 9, 2021

Resolves #1432

Case-insensitive; also accepts "infinity".

Does this also need some testing or some logic to stop people using nan or inf as unit names?

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@clbarnes
Parse inf and nan in Quantity
b8001b3 
Resolves hgrecco#1432

Case-insensitive; also accepts "infinity".
@jules-ch jules-ch merged commit 80bdd5e into hgrecco:master Dec 9, 2021
@keewis keewis mentioned this pull request Jan 16, 2022
Closed
21 tasks
@clbarnes clbarnes mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle infinity while parsing Quantity strings
2 participants
@clbarnes @jules-ch