Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most pytest warnings #1478

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Remove most pytest warnings #1478

merged 1 commit into from
Mar 26, 2022

Conversation

jules-ch
Copy link
Collaborator

@jules-ch jules-ch commented Mar 1, 2022

No description provided.

@jules-ch jules-ch force-pushed the fix-pytests-warnings branch 2 times, most recently from 4804a56 to 5a8a982 Compare March 2, 2022 13:41
@keewis keewis mentioned this pull request Mar 2, 2022
Closed
21 tasks
@keewis
Copy link
Contributor

keewis commented Mar 11, 2022

if you can fix the linting errors this should be ready for merging

@jules-ch
Copy link
Collaborator Author

Now docs build is failing because of jupyter/nbconvert#1736

@keewis
Copy link
Contributor

keewis commented Mar 26, 2022 •
edited
Loading

yes, to fix that you can pin jinja2<3.1 until nbconvert is updated, but the interesting part is: RTD does not fail. Maybe we should just abandon the Documentation Build CI?

Edit: actually, that's because RTD by default will install really old versions of sphinx and jinja2

@jules-ch jules-ch merged commit c4ddc27 into hgrecco:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jules-ch @keewis