Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper benchmark #1824

Closed
wants to merge 14 commits into from

Conversation

Saelyos
Copy link
Contributor

@Saelyos Saelyos commented Jul 20, 2023

In relation to #1792, I added some basic tests to cover the performances of the wrapper. I also made some small changes to improve the performances:

image

There are definitely some ways to improve it again (especially by removing the call to bind), but that would require bigger internal changes.

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 20, 2023

CodSpeed Performance Report

Merging #1824 will improve performances by ×6.2

Comparing RoseauTechnologies:wrapper-benchmark (603b4d6) with develop (295e39c)

Summary

🔥 1 improvements
✅ 420 untouched benchmarks

🆕 18 new benchmarks

Benchmarks breakdown

Benchmark develop RoseauTechnologies:wrapper-benchmark Change
🆕 test_wrapper[int_meter] N/A 291 µs N/A
🆕 test_wrapper[int_kilometer] N/A 276.6 µs N/A
🆕 test_wrapper[float_meter] N/A 272 µs N/A
🆕 test_wrapper[float_kilometer] N/A 300.8 µs N/A
🆕 test_wrapper[complex_meter] N/A 277.9 µs N/A
🆕 test_wrapper[complex_kilometer] N/A 259.9 µs N/A
🆕 test_wrapper_nonstrict[int_meter] N/A 182 µs N/A
🆕 test_wrapper_nonstrict[int_kilometer] N/A 187 µs N/A
🆕 test_wrapper_nonstrict[float_meter] N/A 177.1 µs N/A
🆕 test_wrapper_nonstrict[float_kilometer] N/A 173.8 µs N/A
🆕 test_wrapper_nonstrict[complex_meter] N/A 174.6 µs N/A
🆕 test_wrapper_nonstrict[complex_kilometer] N/A 174.7 µs N/A
🆕 test_wrapper_ret[int_meter] N/A 348 µs N/A
🆕 test_wrapper_ret[int_kilometer] N/A 351.6 µs N/A
🆕 test_wrapper_ret[float_meter] N/A 359.7 µs N/A
🆕 test_wrapper_ret[float_kilometer] N/A 351.2 µs N/A
🆕 test_wrapper_ret[complex_meter] N/A 348.5 µs N/A
🆕 test_wrapper_ret[complex_kilometer] N/A 347.3 µs N/A
🔥 test_base_units[meter] 1,444 µs 231.7 µs ×6.2

@Saelyos Saelyos changed the base branch from develop to master October 20, 2023 07:55
@Saelyos Saelyos closed this Oct 20, 2023
@Saelyos Saelyos deleted the wrapper-benchmark branch October 20, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants