support timedelta in Q_.init #1978
Conversation
There was a problem hiding this comment.
I've got a couple of comments, mostly regarding timedelta64 and where to put the code handling it.
I would also like to have a way to convert a quantity with dimension [time] to a timedelta64, but that can be its own PR (the API is not quite clear to me: should to special-case units of timedelta64[us], for example?).
pint/facets/plain/quantity.py
Outdated
| if is_timedelta(value) or is_timedelta_array(value): | ||
| inst._magnitude = to_seconds(value) |
There was a problem hiding this comment.
would it be possible to special-case numpy.timedelta64, probably in the numpy facet? That way we could roundtrip exactly
pint/compat.py
Outdated
| if isinstance(obj, datetime.timedelta): | ||
| return obj.total_seconds() | ||
| elif isinstance(obj, np_timedelta64) or obj.dtype == np_timedelta64: | ||
| return obj.astype(float) |
There was a problem hiding this comment.
this is not going to work in general: timedelta64 has its own units, which can range from days (or years?) to nanoseconds, and astype(float) is the equivalent of magnitude. I don't have any advice on how to extract that, though, other than parsing the string repr of the dtype.
|
It looks like this is ready for another review |
pre-commit run --all-fileswith no errors