CODATA 2022 update #2049
Open
CODATA 2022 update #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2049 will degrade performances by 21.46%Comparing Summary
Benchmarks breakdown
|
added 2 commits
August 22, 2024 14:08
Like most "measured constants", they're not measured directly, but derived from other measures. However, the list of CODATA values includes these (and their uncertainties and correlations), so it's better to treat them as other constants.
|
Is there anything I should fix? I don't think any documentation (beyond the changelog) or any new test is needed. And surely the PR is not going to be rejected for those µs in the benchmark? |
|
No, nothing to fix. It needs a maintainer to take the time to confirm the
numbers are all correct.
…On Mon, 23 Sept 2024, 13:55 Jellby, ***@***.***> wrote:
Is there anything I should fix? I don't think any documentation (beyond
the changelog) or any new test is needed. And surely the PR is not going to
be rejected for those µs in the benchmark?
—
Reply to this email directly, view it on GitHub
<#2049 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEMLEDVP7M5E3F5MZUXC3TZYAFSTAVCNFSM6AAAAABM4CR6Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGE2DCNZQGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update physical constant values to the latest CODATA 2022 recommended values (from https://pml.nist.gov/cuu/Constants/). Small change, but there's no reason to stay outdated 😁
pre-commit run --all-fileswith no errors