Forbid missing Debug implementations (yewstack#673)

* Forbid missing debug implementations

* someday I'll remember to run cargo fmt before pushing the first time

* add debug for other format types

* derive debug for HandlerId

src/agent.rs

@@ -52,7 +52,7 @@ impl<T: Serialize + for<'de> Deserialize<'de>> Packed for T {
 type SharedOutputSlab<AGN> = Shared<Slab<Option<Callback<<AGN as Agent>::Output>>>>;
 
 /// Id of responses handler.
-#[derive(Serialize, Deserialize, Eq, PartialEq, Hash, Clone, Copy)]
+#[derive(Debug, Serialize, Deserialize, Eq, PartialEq, Hash, Clone, Copy)]
 pub struct HandlerId(usize, bool);
 
 impl HandlerId {
@@ -249,6 +249,7 @@ thread_local! {
 }
 
 /// Create a single instance in the current thread.
+#[allow(missing_debug_implementations)]
 pub struct Context;
 
 impl Discoverer for Context {
@@ -344,6 +345,7 @@ impl<AGN: Agent> Drop for ContextBridge<AGN> {
 }
 
 /// Create an instance in the current thread.
+#[allow(missing_debug_implementations)]
 pub struct Job;
 
 impl Discoverer for Job {
@@ -397,6 +399,7 @@ impl<AGN: Agent> Drop for JobBridge<AGN> {
 // <<< SEPARATE THREAD >>>
 
 /// Create a new instance for every bridge.
+#[allow(missing_debug_implementations)]
 pub struct Private;
 
 impl Discoverer for Private {
@@ -438,6 +441,12 @@ pub struct PrivateBridge<T: Agent> {
     _agent: PhantomData<T>,
 }
 
+impl<AGN: Agent> fmt::Debug for PrivateBridge<AGN> {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("PrivateBridge<_>")
+    }
+}
+
 impl<AGN: Agent> Bridge<AGN> for PrivateBridge<AGN> {
     fn send(&mut self, msg: AGN::Input) {
         // TODO Important! Implement.
@@ -494,6 +503,7 @@ thread_local! {
 }
 
 /// Create a single instance in a tab.
+#[allow(missing_debug_implementations)]
 pub struct Public;
 
 impl Discoverer for Public {
@@ -555,10 +565,16 @@ impl Discoverer for Public {
 impl Dispatchable for Public {}
 
 /// A connection manager for components interaction with workers.
-pub struct PublicBridge<T: Agent> {
+pub struct PublicBridge<AGN: Agent> {
     worker: Value,
     id: HandlerId,
-    _agent: PhantomData<T>,
+    _agent: PhantomData<AGN>,
+}
+
+impl<AGN: Agent> fmt::Debug for PublicBridge<AGN> {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("PublicBridge<_>")
+    }
 }
 
 impl<AGN: Agent> PublicBridge<AGN> {
@@ -636,6 +652,7 @@ impl<AGN: Agent> Drop for PublicBridge<AGN> {
 }
 
 /// Create a single instance in a browser.
+#[allow(missing_debug_implementations)]
 pub struct Global;
 
 impl Discoverer for Global {}
@@ -681,6 +698,12 @@ pub struct AgentScope<AGN: Agent> {
     shared_agent: Shared<AgentRunnable<AGN>>,
 }
 
+impl<AGN: Agent> fmt::Debug for AgentScope<AGN> {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("AgentScope<_>")
+    }
+}
+
 impl<AGN: Agent> Clone for AgentScope<AGN> {
     fn clone(&self) -> Self {
         AgentScope {

src/app.rs

@@ -5,6 +5,7 @@ use crate::html::{Component, Scope};
 use stdweb::web::{document, Element, INode, IParentNode};
 
 /// An application instance.
+#[derive(Debug)]
 pub struct App<COMP: Component> {
     /// `Scope` holder
     scope: Scope<COMP>,

src/components/select.rs

@@ -37,18 +37,20 @@ use crate::html::{ChangeData, Component, ComponentLink, Html, ShouldRender};
 use crate::macros::{html, Properties};
 
 /// `Select` component.
+#[derive(Debug)]
 pub struct Select<T> {
     props: Props<T>,
 }
 
 /// Internal message of the component.
+#[derive(Debug)]
 pub enum Msg {
     /// This message indicates the option with id selected.
     Selected(Option<usize>),
 }
 
 /// Properties of `Select` component.
-#[derive(PartialEq, Properties)]
+#[derive(PartialEq, Properties, Debug)]
 pub struct Props<T> {
     /// Initially selected value.
     pub selected: Option<T>,

src/format/cbor.rs

@@ -16,6 +16,7 @@ use serde_cbor;
 /// let Cbor(data) = dump;
 ///# }
 /// ```
+#[derive(Debug)]
 pub struct Cbor<T>(pub T);
 
 binary_format!(Cbor based on serde_cbor);

src/format/json.rs

@@ -12,6 +12,7 @@
 /// // Converts JSON string to a data (lazy).
 /// let Json(data) = dump;
 /// ```
+#[derive(Debug)]
 pub struct Json<T>(pub T);
 
 text_format!(Json based on serde_json);

src/format/msgpack.rs

@@ -17,6 +17,7 @@ use rmp_serde;
 /// let MsgPack(data) = dump;
 ///# }
 /// ```
+#[derive(Debug)]
 pub struct MsgPack<T>(pub T);
 
 binary_format!(MsgPack based on rmp_serde);

src/format/nothing.rs

@@ -4,6 +4,7 @@ use super::{Binary, Text};
 use failure::err_msg;
 
 /// A representation of an empty data. Nothing stored. Nothing restored.
+#[derive(Debug)]
 pub struct Nothing;
 
 impl Into<Text> for Nothing {

src/format/toml.rs

@@ -16,6 +16,7 @@ use toml;
 /// let Toml(data) = dump;
 /// }
 /// ```
+#[derive(Debug)]
 pub struct Toml<T>(pub T);
 
 text_format!(Toml based on toml);

src/format/yaml.rs

@@ -17,6 +17,7 @@ use serde_yaml;
 /// let Yaml(data) = dump;
 ///# }
 /// ```
+#[derive(Debug)]
 pub struct Yaml<T>(pub T);
 
 text_format!(Yaml based on serde_yaml);

src/html/listener.rs

@@ -17,6 +17,7 @@ macro_rules! impl_action {
 
             /// A wrapper for a callback.
             /// Listener extracted from here when attached.
+            #[allow(missing_debug_implementations)]
             pub struct Wrapper<F>(Option<F>);
 
             /// And event type which keeps the returned type.

src/html/mod.rs

@@ -282,6 +282,7 @@ pub trait Properties {
 }
 
 /// Builder for when a component has no properties
+#[derive(Debug)]
 pub struct EmptyBuilder;
 
 impl Properties for () {

src/html/scope.rs

@@ -25,6 +25,12 @@ pub struct Scope<COMP: Component> {
     shared_state: Shared<ComponentState<COMP>>,
 }
 
+impl<COMP: Component> fmt::Debug for Scope<COMP> {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("Scope<_>")
+    }
+}
+
 impl<COMP: Component> Clone for Scope<COMP> {
     fn clone(&self) -> Self {
         Scope {

src/lib.rs

@@ -55,6 +55,7 @@
 
 #![deny(
     missing_docs,
+    missing_debug_implementations,
     bare_trait_objects,
     anonymous_parameters,
     elided_lifetimes_in_paths

src/services/console.rs

@@ -5,7 +5,7 @@ use stdweb::{_js_impl, js};
 
 /// A service to use methods of a
 /// [Console](https://developer.mozilla.org/en-US/docs/Web/API/Console).
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct ConsoleService {}
 
 impl ConsoleService {

src/services/dialog.rs

@@ -6,7 +6,7 @@ use stdweb::Value;
 use stdweb::{_js_impl, js};
 
 /// A dialog service.
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct DialogService {}
 
 impl DialogService {

src/services/fetch.rs

@@ -6,6 +6,7 @@ use crate::format::{Binary, Format, Text};
 use failure::Fail;
 use serde::Serialize;
 use std::collections::HashMap;
+use std::fmt;
 use stdweb::serde::Serde;
 use stdweb::unstable::{TryFrom, TryInto};
 use stdweb::web::ArrayBuffer;
@@ -16,7 +17,7 @@ use stdweb::{_js_impl, js};
 pub use http::{HeaderMap, Method, Request, Response, StatusCode, Uri};
 
 /// Type to set cache for fetch.
-#[derive(Serialize)]
+#[derive(Serialize, Debug)]
 #[serde(rename_all = "kebab-case")]
 pub enum Cache {
     /// `default` value of cache.
@@ -35,7 +36,7 @@ pub enum Cache {
 }
 
 /// Type to set credentials for fetch.
-#[derive(Serialize)]
+#[derive(Serialize, Debug)]
 #[serde(rename_all = "kebab-case")]
 pub enum Credentials {
     /// `omit` value of credentials.
@@ -47,7 +48,7 @@ pub enum Credentials {
 }
 
 /// Type to set mode for fetch.
-#[derive(Serialize)]
+#[derive(Serialize, Debug)]
 #[serde(rename_all = "kebab-case")]
 pub enum Mode {
     /// `same-origin` value of mode.
@@ -59,7 +60,7 @@ pub enum Mode {
 }
 
 /// Type to set redirect behaviour for fetch.
-#[derive(Serialize)]
+#[derive(Serialize, Debug)]
 #[serde(rename_all = "kebab-case")]
 pub enum Redirect {
     /// `follow` value of redirect.
@@ -72,7 +73,7 @@ pub enum Redirect {
 
 /// Init options for `fetch()` function call.
 /// https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/fetch
-#[derive(Serialize, Default)]
+#[derive(Serialize, Default, Debug)]
 pub struct FetchOptions {
     /// Cache of a fetch request.
     #[serde(skip_serializing_if = "Option::is_none")]
@@ -99,8 +100,14 @@ enum FetchError {
 #[must_use]
 pub struct FetchTask(Option<Value>);
 
+impl fmt::Debug for FetchTask {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("FetchTask")
+    }
+}
+
 /// A service to fetch resources.
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct FetchService {}
 
 impl FetchService {

src/services/interval.rs

@@ -3,6 +3,7 @@
 
 use super::{to_ms, Task};
 use crate::callback::Callback;
+use std::fmt;
 use std::time::Duration;
 use stdweb::Value;
 #[allow(unused_imports)]
@@ -13,8 +14,14 @@ use stdweb::{_js_impl, js};
 #[must_use]
 pub struct IntervalTask(Option<Value>);
 
+impl fmt::Debug for IntervalTask {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("IntervalTask")
+    }
+}
+
 /// A service to send messages on every elapsed interval.
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct IntervalService {}
 
 impl IntervalService {

src/services/keyboard.rs

@@ -1,5 +1,6 @@
 //! Service to register key press event listeners on elements.
 use crate::callback::Callback;
+use std::fmt;
 use stdweb::web::event::{KeyDownEvent, KeyPressEvent, KeyUpEvent};
 use stdweb::web::{EventListenerHandle, IEventTarget};
 
@@ -12,13 +13,20 @@ use stdweb::web::{EventListenerHandle, IEventTarget};
 ///
 /// This service is for adding key event listeners to elements that don't support these attributes,
 /// like the `document` or `<canvas>` elements for example.
+#[derive(Debug)]
 pub struct KeyboardService {}
 
 /// Handle to the key event listener.
 ///
 /// When it goes out of scope, the listener will be removed from the element.
 pub struct KeyListenerHandle(Option<EventListenerHandle>);
 
+impl fmt::Debug for KeyListenerHandle {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("KeyListenerHandle")
+    }
+}
+
 impl KeyboardService {
     /// Registers a callback that listens to KeyPressEvents on a provided element.
     ///

src/services/reader.rs

@@ -3,6 +3,7 @@
 use super::Task;
 use crate::callback::Callback;
 use std::cmp;
+use std::fmt;
 use stdweb::unstable::TryInto;
 use stdweb::web::event::LoadEndEvent;
 pub use stdweb::web::{Blob, File, IBlob};
@@ -39,7 +40,7 @@ pub enum FileChunk {
 }
 
 /// A reader service attached to a user context.
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct ReaderService {}
 
 impl ReaderService {
@@ -135,6 +136,12 @@ pub struct ReaderTask {
     file_reader: FileReader,
 }
 
+impl fmt::Debug for ReaderTask {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str("ReaderTask")
+    }
+}
+
 impl Task for ReaderTask {
     fn is_active(&self) -> bool {
         self.file_reader.ready_state() == FileReaderReadyState::Loading