Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write the file unless there are changes #457

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Don't write the file unless there are changes #457

merged 2 commits into from
Dec 12, 2018

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Dec 9, 2018

this was originally brought up in pre-commit/pre-commit-hooks#336 -- though I've noticed this annoyance myself as well 🙃

this was surprisingly difficult to test!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.589% when pulling fce5e18 on asottile:dont_write_unless_changes into 48662f6 on hhatto:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.589% when pulling fce5e18 on asottile:dont_write_unless_changes into 48662f6 on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.589% when pulling fce5e18 on asottile:dont_write_unless_changes into 48662f6 on hhatto:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.589% when pulling fce5e18 on asottile:dont_write_unless_changes into 48662f6 on hhatto:master.

@hhatto hhatto self-requested a review December 9, 2018 14:42
@hhatto
Copy link
Owner

hhatto commented Dec 12, 2018

LGTM

Thanks 👍

@hhatto hhatto merged commit 1c392bc into hhatto:master Dec 12, 2018
@asottile asottile deleted the dont_write_unless_changes branch December 12, 2018 15:47
@asottile
Copy link
Contributor Author

@hhatto any chance this can appear in a release?

@hhatto
Copy link
Owner

hhatto commented Apr 14, 2019

@asottile
version 1.4.4 has been released. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhatto hhatto hhatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile @coveralls @hhatto