Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add https protocol #17

Merged
merged 2 commits into from
Jul 1, 2021
Merged

add https protocol #17

merged 2 commits into from
Jul 1, 2021

Conversation

tetsuo-dance
Copy link
Contributor

概要

  • protocolにhtttpsの追加

背景

  • クラウド環境に存在するgroongaサーバに対してhttpsロードバランサ経由でアクセスさせたい。

改修内容

  • Groongaのcallメソッドに関してhttpsの条件を追加。
  • テスト追加

備考

  • お忙しいところ恐縮ですがこちらお手隙の際に確認/検討のほどお願いいたします。

@tetsuo-dance tetsuo-dance reopened this Jul 1, 2021
@tetsuo-dance
Copy link
Contributor Author

すみません、masterが進んでいたのでmergeしてconfilictを解消いたしました。
ご確認よろしくお願いいたします。

@hhatto hhatto self-requested a review July 1, 2021 12:56
@hhatto
Copy link
Owner

hhatto commented Jul 1, 2021

Thanks

@hhatto hhatto merged commit b08aa26 into hhatto:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhatto hhatto Awaiting requested review from hhatto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetsuo-dance @hhatto