Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow: add support for error message #21

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

kou
Copy link
Contributor

@kou kou commented Nov 2, 2023

It's supported since Groonga 13.0.9.

Sorry the documentation for this doesn't exist...

See the following expected test result for schema: https://github.com/groonga/groonga/blob/2749a4a65b0914cfaa5b6c4f9c7dcc883ed5560d/test/command/suite/select/command_version/3/apache_arrow/syntax_error.expected#L9-L20

@kou
Copy link
Contributor Author

kou commented Nov 2, 2023

#19 is needed for CI.

I confirmed that this works on my fork: https://github.com/kou/poyonga/actions/runs/6729713687/job/18291053903

It's supported since Groonga 13.0.9.

Sorry the documentation for this doesn't exist...

See the following expected test result for schema:
https://github.com/groonga/groonga/blob/2749a4a65b0914cfaa5b6c4f9c7dcc883ed5560d/test/command/suite/select/command_version/3/apache_arrow/syntax_error.expected#L9-L20
@kou
Copy link
Contributor Author

kou commented Nov 2, 2023

#19 has been merged.
I've rebased on master.

@hhatto hhatto self-requested a review November 3, 2023 00:33
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!!

@hhatto hhatto merged commit b31602b into hhatto:master Nov 3, 2023
10 checks passed
@hhatto
Copy link
Owner

hhatto commented Nov 3, 2023

A new version will be released within a few days. (v0.6.0 or v1.0.0)

@kou kou deleted the arrow-error-information branch November 3, 2023 22:19
@kou
Copy link
Contributor Author

kou commented Nov 3, 2023

Thanks!

FYI: I have one more patch for Groonga 13.0.9. I'll open a pull request with it in a few days.
You may want to wait for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants