Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

自动审核只要加上注释就会自动审核通过[问题咨询] #949

Closed
jiachen1230 opened this issue Oct 30, 2020 · 1 comment
Closed

自动审核只要加上注释就会自动审核通过[问题咨询] #949

jiachen1230 opened this issue Oct 30, 2020 · 1 comment
Labels
question Further information is requested

Comments

@jiachen1230
Copy link

问题描述

详细描述你的操作步骤和结果，以及你的疑问
如题，只要在上线审核工单(update)前面加上注释信息，就会自动审核通过
image

image

版本信息

  • 应用版本/分支：Release v1.4.5
  • 部署方式：Docker、手工部署
@jiachen1230 jiachen1230 added the question Further information is requested label Oct 30, 2020
@blookerP
Copy link

我也刚遇到这个问题
不过在/sql/utils/sql_review.py内加上
from .sql_utils/ import remove_comments
并在is_auto_review()中sql_content = workflow.sqlworkflowcontent.sql_content下面
加上sql_content = remove_comments(sql_content)好像可以解决一部分问题，不过还没有测试过其他场景

hhyo added a commit that referenced this issue Oct 31, 2020
@hhyo
解决DML语句包含头部注释会绕过自动审批判断的问题 fix #949
eb4bb0d 
移除sqlparse解析和Inception二次检测，提高判断效率
@hhyo hhyo closed this as completed in 47d1242 Oct 31, 2020
hhyo added a commit that referenced this issue Oct 31, 2020
@hhyo
解决DML语句包含头部注释会绕过自动审批判断的问题 fix #949
6928f04 
移除sqlparse解析和Inception二次检测，提高判断效率
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jiachen1230 @blookerP