Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.sql查询 新增redis帮助文档;完全禁止keys命令 #157

Merged
merged 3 commits into from
Apr 29, 2019
Merged

1.sql查询 新增redis帮助文档;完全禁止keys命令 #157

merged 3 commits into from
Apr 29, 2019

Conversation

kjiLupin
Copy link
Collaborator

2.其他一些小东西修改

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #157 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   73.91%   73.91%   -0.01%     
==========================================
  Files          62       62              
  Lines        6687     6686       -1     
==========================================
- Hits         4943     4942       -1     
  Misses       1744     1744
Impacted Files Coverage Δ
sql/instance.py 44.74% <ø> (ø) ⬆️
sql/engines/redis.py 83.75% <100%> (-0.21%) ⬇️
sql/models.py 94.52% <100%> (ø) ⬆️
sql/admin.py 100% <100%> (ø) ⬆️
sql/query.py 52.71% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d31175...4a18b93. Read the comment docs.

@@ -175,9 +175,6 @@
# LDAP
ENABLE_LDAP = False
if ENABLE_LDAP:
import ldap
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里去除验证过么有影响的吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import ldap 这个没用的。我们一直在用ldap的。

@@ -440,11 +440,11 @@ class ParamHistory(models.Model):
set_sql = models.CharField('在线变更配置执行的SQL语句', max_length=1024)
user_name = models.CharField('修改人', max_length=30)
user_display = models.CharField('修改人中文名', max_length=50)
update_time = models.DateTimeField('修改时间', auto_now_add=True)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model定义的变更都需要提供变更语句,目前版本v1.5.3,新SQL文件定义为v1.5.3_v1.5.4.sql,放在init_sql目录下

Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照上面的反馈简单调整一下~

@hhyo hhyo merged commit ef8e91a into hhyo:master Apr 29, 2019
@PU-101
Copy link
Contributor

PU-101 commented Jun 12, 2020

请问为什么要禁止keys,我看redis帮助文档里有:
2、keys pattern 查找所有符合给定模式的key,通常用于查找key

@dongqianzheng
Copy link
Contributor

是否能支持下zset相关命令呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants