-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine增加escape_string用于处理字符串参数转义 #2107
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
- Coverage 75.51% 75.50% -0.02%
==========================================
Files 102 102
Lines 14910 14928 +18
==========================================
+ Hits 11259 11271 +12
- Misses 3651 3657 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mysql 那部分参数化的代码,应该也可以用,要不要都加? |
可以加,不冲突,分两个pr,这个要不就叫新增参数化支持,可以不涉及注入相关调整,就把支持的引擎统一新增执行参数支持 |
也行, 那新开一个pr 吧, 这个你先 merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
可以直接在公有项目开pr,私有分支这边删除了,pg的琢磨半天也只能调整为参数化形式 |
发现clickhouse也一样,这些内置转义方法都是用于参数化处理的,不能和字符串格式化混用,你先提交MySQL的参数化pr,合并后,后续其他engine我这边统一处理下 |
增加 mysql、clickhouse的参数转义,适用于库、表等用户参数处理
相关pr:#2062