Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复pgsql数据库下执行计划查看 #2638

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

peixubin
Copy link
Contributor

在pgsql模式下,在线查询功能的执行计划错误的执行了SQL,没有显示执行计划;仅在配置了disable_star下,才禁止带*查询

@peixubin
Copy link
Contributor Author

希望尽快合并,后续还有pgsql的自动审核功能

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试和 lint 通过, 单元测试达标是基本要求, 请核对

@peixubin
Copy link
Contributor Author

麻烦先撤销这个pr

@LeoQuote
Copy link
Collaborator

你好, 有更新可以继续往上推送, 如非必要请不要新开 issue

@LeoQuote LeoQuote marked this pull request as draft May 13, 2024 09:37
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (f81fb45) to head (dad3cc5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2638   +/-   ##
=======================================
  Coverage   77.11%   77.11%           
=======================================
  Files         117      117           
  Lines       16165    16170    +5     
=======================================
+ Hits        12465    12470    +5     
  Misses       3700     3700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peixubin peixubin marked this pull request as ready for review May 14, 2024 07:31
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢贡献👍

@LeoQuote LeoQuote merged commit 14fbd5e into hhyo:master May 14, 2024
10 checks passed
feiazifeiazi pushed a commit to feiazifeiazi/Archery_Genuine2 that referenced this pull request Jun 20, 2024
* 修复pgsql数据库下执行计划查看

* linter format

* pgsql:还原query_check,不检查disable_star

* pgsql query_check: add explain test

* python format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants