Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create tiny-react #144

Merged
merged 193 commits into from
Oct 17, 2023
Merged

feat: create tiny-react #144

merged 193 commits into from
Oct 17, 2023

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Sep 29, 2023

todo (core)

  • text, dom tree
  • fragment
  • functional component
  • useState
  • useLayoutEffect
  • useEffect
  • dom ref callback
  • (re-render schedule/batch) robust handling of multiple "forceUpdate"
  • bugs
    • fix stale "force update" 445875d
    • "force update" in useEffect (workaround by setTimeout/queueMicrotask in user land) (effect is not async on next frame)
    • useEffect deps

todo (chore, dx)

todo (future)

@hi-ogawa hi-ogawa marked this pull request as ready for review October 15, 2023 05:04
@hi-ogawa
Copy link
Owner Author

Probably time to merge as commits on this PR is getting too huge.

@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Oct 15, 2023

Let's merge this if this works fine on production

@hi-ogawa hi-ogawa mentioned this pull request Oct 16, 2023
16 tasks
@hi-ogawa hi-ogawa merged commit 4dbec25 into main Oct 17, 2023
1 check passed
@hi-ogawa hi-ogawa deleted the feat-tiny-react branch October 17, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant