vite: fix "could not fast refresh" false alarm (remix-run#8580)

hi-ogawa · Jan 23, 2024 · 0bc6c12 · 0bc6c12
1 parent 10fcf5b
commit 0bc6c12
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/fast-dodos-yell.md b/.changeset/fast-dodos-yell.md
@@ -0,0 +1,9 @@
+---
+"@remix-run/dev": patch
+---
+
+Vite: fix "could not fast refresh" false alarm
+
+HMR is already functioning correctly but was incorrectly logging that it "could not fast refresh" on internal client routes.
+Now internal client routes correctly register Remix exports like `meta` for fast refresh,
+which removes the false alarm.
diff --git a/packages/remix-dev/vite/plugin.ts b/packages/remix-dev/vite/plugin.ts
@@ -1468,7 +1468,8 @@ function addRefreshWrapper(
   code: string,
   id: string
 ): string {
-  let isRoute = getRoute(pluginConfig, id);
+  let isRoute =
+    id.endsWith(CLIENT_ROUTE_QUERY_STRING) || getRoute(pluginConfig, id);
   let acceptExports = isRoute
     ? [
         "clientAction",