fix(vite): remove legacyCssImports option (remix-run#8096)

hi-ogawa · Nov 22, 2023 · 8c42697 · 8c42697
1 parent 53e2d45
commit 8c42697
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 144 deletions.
diff --git a/.changeset/few-forks-behave.md b/.changeset/few-forks-behave.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+Remove undocumented `legacyCssImports` option from Vite plugin due to issues with `?url` imports of CSS files not being processed correctly in Vite
diff --git a/integration/vite-css-legacy-build-test.ts b/integration/vite-css-legacy-build-test.ts
diff --git a/packages/remix-dev/vite/legacy-css-imports.ts b/packages/remix-dev/vite/legacy-css-imports.ts
diff --git a/packages/remix-dev/vite/plugin.ts b/packages/remix-dev/vite/plugin.ts
@@ -26,7 +26,6 @@ import { createRequestHandler } from "./node/adapter";
 import { getStylesForUrl, isCssModulesFile } from "./styles";
 import * as VirtualModule from "./vmod";
 import { removeExports } from "./remove-exports";
-import { transformLegacyCssImports } from "./legacy-css-imports";
 import { replaceImportSpecifier } from "./replace-import-specifier";
 
 // We reassign the "vite" variable from a dynamic import of Vite's ESM build
@@ -69,9 +68,7 @@ type RemixConfigJsdocOverrides = {
 };
 
 export type RemixVitePluginOptions = RemixConfigJsdocOverrides &
-  Omit<SupportedRemixConfig, keyof RemixConfigJsdocOverrides> & {
-    legacyCssImports?: boolean;
-  };
+  Omit<SupportedRemixConfig, keyof RemixConfigJsdocOverrides>;
 
 type ResolvedRemixVitePluginConfig = Pick<
   ResolvedRemixConfig,
@@ -1092,19 +1089,6 @@ export const remixVitePlugin: RemixVitePlugin = (options = {}) => {
         return modules;
       },
     },
-    ...((options.legacyCssImports
-      ? [
-          {
-            name: "remix-legacy-css-imports",
-            enforce: "pre",
-            transform(code) {
-              if (code.includes('.css"') || code.includes(".css'")) {
-                return transformLegacyCssImports(code);
-              }
-            },
-          },
-        ]
-      : []) satisfies Vite.Plugin[]),
   ];
 };