New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify PR-8057 #1

Closed

hi-ogawa wants to merge 3 commits into fix-vite-resolveFileUrl-normalizePath-out-of-tree from chore-verify-8057

Owner

hi-ogawa commented Nov 19, 2023 •

edited

Loading

Quick and dirty way to verify the behavior on Windows?

fix(vite): apply normalizePath to default entry file outside of project directory remix-run/remix#8057


          chore: test "@fs" url on ci

eac9561

hi-ogawa changed the title ~~verify 8057~~ verify PR-8057

hi-ogawa added 2 commits

November 19, 2023 15:50


          ci: run ci on fork repo

40c93a1


          fix: join?

5d50b8a

Owner Author

hi-ogawa commented Nov 21, 2023

This doesn't seem to be a best way to test. One Windows user said the patch works alright, so hoping it's okay.

hi-ogawa closed this

hi-ogawa deleted the chore-verify-8057 branch

November 21, 2023 05:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet