Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): remove unused theme keys #85

Merged
merged 6 commits into from
Oct 1, 2023

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Oct 1, 2023

By filtering useless variables, it saves about 10KB:

# before
$ pnpm -C packages/app -s build
vite v4.4.9 building for production...
✓ 130 modules transformed.
dist/index.html                   2.20 kB │ gzip:   0.96 kB
dist/assets/index-cd362aed.css   52.80 kB │ gzip:  10.06 kB
dist/assets/index-0022a56b.js   389.10 kB │ gzip: 122.90 kB │ map: 1,532.15 kB
✓ built in 2.16s

# after
$ pnpm -C packages/app -s build
vite v4.4.9 building for production...
✓ 130 modules transformed.
dist/index.html                   2.20 kB │ gzip:   0.96 kB
dist/assets/index-4bbc95c7.css   42.30 kB │ gzip:   7.67 kB
dist/assets/index-a845fe92.js   376.89 kB │ gzip: 119.86 kB │ map: 1,506.09 kB
✓ built in 2.15s
generated css

image

@hi-ogawa hi-ogawa merged commit fa5b258 into main Oct 1, 2023
1 check passed
@hi-ogawa hi-ogawa deleted the refactor-lib-remove-unused-variables branch October 1, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: slim-down css variables in preflight css
1 participant